Repository navigation
chore(inference): xAI Grok causing problems, switching to OpenAI GPT Sol - #7913
Conversation
PR Summary by QodoSwitch code and review subagents from Grok to GPT Sol
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1.
|
|
🤖 Review · Commit: |
waynesun09
left a comment
There was a problem hiding this comment.
code → openai/gpt-6.1-sol looks good. The review change needs one more line, though. As written, every review run fails at bootstrap.
With the review parent still on sonnet (Vertex), pi only accepts sub-agent models that are Claude aliases, Vertex Gemini, xai-vertex/xai/grok-4.6, or the parent's own model (piTrustedSpecs, internal/runtime/pi_personas.go). challenger/correctness/security are named in config, so the out-of-set model is fatal:
persona "security": resolved model "openai/gpt-6.1-sol" is not available in this run; accepted: anthropic-vertex/..., google-vertex/..., xai-vertex/xai/grok-4.6
Also, NeedsOpenAIProvider only looks at the parent model, so a Vertex parent would never get the OpenAI provider for those children anyway.
Fix: move the review parent to OpenAI too (suggestion inline). I checked this on main: OpenAI personas resolve, the Gemini personas still resolve, and NeedsOpenAIProvider is true.
e9a5290 to
2f3217c
Compare
|
🤖 Review · Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2f3217c to
6e6e232
Compare
|
🤖 Review · Commit: |
6e6e232 to
2993e7f
Compare
|
🤖 Review · Commit: |
Signed-off-by: Hector Martinez <hemartin@redhat.com>
2993e7f to
f33f8c0
Compare
Resolved: the review parent moved to openai/gpt-6.1-sol, so the OpenAI sub-agents are allowed and get the OpenAI provider.
|
🤖 Finished Review · ✅ Success · Started 3:05 PM UTC · Completed 3:44 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $2.40 |
|
Review skipped — this PR is already merged. The Posted by fullsend post-review check |
Summary
xAI Grok was slow and barely working today, switching to OpenAI GPT Sol.
Related Issue
Changes
Testing
make lintpasses (stage changes first, then run)Checklist
!for breaking changes)